Skip to content

fix(sdk): the facade names the first SdkError and PushEvent by aliases, so a synchronized copy compiles - #235

Merged
Xyzcancer merged 2 commits into
masterfrom
fix/mirror-legacy-type-names
Nov 17, 2026
Merged

Xyzcancer merged 2 commits into
masterfrom
fix/mirror-legacy-type-names

Conversation

@Xyzcancer

Copy link
Copy Markdown
Contributor

In a synchronized copy the module and the Rees46 facade get the same name, so REES46.SdkError and REES46.PushEvent pointed at the facade's nested types there and the copy of 3.38.0 does not compile. The facade now uses LegacySdkError and LegacyPushEvent, aliases of the same types, and a SwiftLint rule rejects module-qualified names in the core.

…s, so a synchronized copy that renames the module and Rees46 to one word compiles

REES46.SdkError and REES46.PushEvent meant the module's types; in a copy where the module and the
Rees46 facade carry the same name they meant the facade's nested ones, and the copy stopped
compiling. LegacySdkError and LegacyPushEvent name the same types under names every copy keeps,
and a SwiftLint rule rejects a module-qualified name in the core.
@Xyzcancer Xyzcancer closed this Nov 17, 2026
@Xyzcancer Xyzcancer reopened this Nov 17, 2026
@Xyzcancer
Xyzcancer merged commit ce85480 into master Nov 17, 2026
9 of 12 checks passed
@Xyzcancer
Xyzcancer deleted the fix/mirror-legacy-type-names branch November 17, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant