Repository navigation
fix(sdk): the facade names the first SdkError and PushEvent by aliases, so a synchronized copy compiles - #235
Merged
Merged
Conversation
…s, so a synchronized copy that renames the module and Rees46 to one word compiles REES46.SdkError and REES46.PushEvent meant the module's types; in a copy where the module and the Rees46 facade carry the same name they meant the facade's nested ones, and the copy stopped compiling. LegacySdkError and LegacyPushEvent name the same types under names every copy keeps, and a SwiftLint rule rejects a module-qualified name in the core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a synchronized copy the module and the
Rees46facade get the same name, soREES46.SdkErrorandREES46.PushEventpointed at the facade's nested types there and the copy of 3.38.0 does not compile. The facade now usesLegacySdkErrorandLegacyPushEvent, aliases of the same types, and a SwiftLint rule rejects module-qualified names in the core.